ci: wire BCH G3a populated-block gate into CI - #651
Merged
Conversation
The BCH G3a entrypoint tests/gates/bch_g3a_regtest_block_production.sh has been on master since the gate-scripts landing but no workflow invoked it — orphaned alongside G3b until #650 wired G3b. This mirrors that template: network-free CHECK-harness CI arm always on (embedded-daemon assembly, block broadcast, CTOR ordering, CashTokens transparency, coinbase KAT) with a false-green guard; opt-in live regtest BCHN arm gated on BCH_RPC_PASS/AUTH. Neutral green no-op on branches predating the entrypoint. Register as a required check only after a confirmed non-hollow green rollup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #650 (G3b). The BCH G3a entrypoint
tests/gates/bch_g3a_regtest_block_production.shhas been on master since the gate-scripts landing but no workflow invoked it — orphaned. This wires it, mirroring the #650 G3b template.CI arm (network-free, always on): in-process CHECK-harnesses proving populated-block production without a live BCHN — embedded-daemon assembly, embedded block broadcast, CTOR block ordering, CashTokens transparency, coinbase byte-vector KAT — with a false-green guard demanding the full expected test count ran.
Live regtest arm (opt-in): runs only when
BCH_RPC_PASS+BCH_RPC_AUTHpoint at an isolated regtest BCHN; unset here, so the network-free arm carries the gate.CI plumbing only — no consensus/shared-base/build.yml/CMake surface. Neutral green no-op on branches predating the entrypoint. Self-hosted for same-repo events, gh-hosted fallback for fork PRs (RCE gate intact). Register as a required check only after a confirmed non-hollow green rollup (operator-side ruleset).